Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swarm): remove deprecated NetworkBehaviourAction type #3919

Merged
merged 5 commits into from
May 14, 2023
Merged

feat(swarm): remove deprecated NetworkBehaviourAction type #3919

merged 5 commits into from
May 14, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from mxinden May 14, 2023 10:32
thomaseizinger
thomaseizinger commented May 14, 2023
View reviewed changes
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger removed the request for review from mxinden May 14, 2023 10:34
@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels May 14, 2023
@mergify

This comment was marked as resolved.

Sign in to view
@mergify mergify bot merged commit 38c0804 into master May 14, 2023
@mergify mergify bot deleted the remove-deprecated-nba branch May 14, 2023 11:23
mxinden
mxinden reviewed May 15, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden